[PATCH] D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 01:49:40 PST 2022


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one final suggestion.



================
Comment at: llvm/test/tools/llvm-objcopy/COFF/pe-fields.test:5-7
+# RUN: not llvm-objcopy --subsystem windows %t.in.obj %t.out.obj 2>&1 | FileCheck %s
+
+# CHECK: '{{.*}}.in.obj': unable to set subsystem on a relocatable object file
----------------
This is how we usually check the file names in error messages.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116556/new/

https://reviews.llvm.org/D116556



More information about the llvm-commits mailing list