[PATCH] D116881: [ELF] Add Resolver class to relocation scan pass. NFC

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:435
+  ArrayRef<EhSectionPiece> pieces;
+  size_t i = 0;
+
----------------
`i` should be changed to something more self-explanatory. Or, maybe, `OffsetGetter` should be preserved as a separate class because it implements isolated functionality.


================
Comment at: lld/ELF/Relocations.cpp:1285
   const RelTy &rel = *i;
-  uint32_t symIndex = rel.getSymbol(config->isMips64EL);
+  uint32_t symIndex = rel.getSymbol(0);
   Symbol &sym = sec.getFile<ELFT>()->getSymbol(symIndex);
----------------
Why `config->isMips64EL` is changed to `0`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116881/new/

https://reviews.llvm.org/D116881