[PATCH] D115092: [lld-macho] Unreferenced weak dylib symbols shouldn't fetch archive symbols

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 9 22:19:21 PST 2022


MaskRay added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:194
+      if (dysym->getRefState() != RefState::Unreferenced)
+        file->fetch(sym);
+      else
----------------
`file->fetch(sym);` is not covered by tests. D116916 will add the coverage.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115092/new/

https://reviews.llvm.org/D115092



More information about the llvm-commits mailing list