[PATCH] D116916: [lld-macho][test] Add missing coverage for archive/dylib resolution after D115092

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 9 22:02:29 PST 2022


MaskRay created this revision.
MaskRay added reviewers: lld-macho, int3, oontvoo.
Herald added a project: lld-macho.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When `file->fetch(sym)` is replaced with a no-op, no test fails.

The new test catches the case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116916

Files:
  lld/test/MachO/weak-definition-direct-fetch.s


Index: lld/test/MachO/weak-definition-direct-fetch.s
===================================================================
--- lld/test/MachO/weak-definition-direct-fetch.s
+++ lld/test/MachO/weak-definition-direct-fetch.s
@@ -101,6 +101,8 @@
 # RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ar-weak-ref-weak-dylib | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT
 # RUN: %lld -dylib -lSystem -o %t/weak-ref-weak-dylib-weak-ar -L%t -lweakfoo %t/weakfoo.a %t/weak-refs-foo.o
 # RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ref-weak-dylib-weak-ar | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT
+# RUN: %lld -dylib -lSystem -o %t/weak-ref-weak-dylib-weak-ar -L%t -lweakfoo %t/weak-refs-foo.o %t/weakfoo.a
+# RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ref-weak-dylib-weak-ar | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT
 
 #--- foo.s
 .globl _foo


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116916.398510.patch
Type: text/x-patch
Size: 872 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220110/cee48058/attachment.bin>


More information about the llvm-commits mailing list