[PATCH] D116849: [M68k][GlobalISel] Fix a big-endian-related bug in CallLowering

[Sheng via Phabricator via llvm-commits]

0x59616e added inline comments.


================
Comment at: llvm/lib/Target/M68k/GISel/M68kCallLowering.cpp:94-96
+    for (auto It = M68kLocs.rbegin(); It != M68kLocs.rend(); ++It) {
+      State.addLoc(*It);
+    }
----------------
arsenm wrote:
> I think it would be more appropriate to reverse the order where the parts were split in the first place (i.e. make splitToValueTypes endian aware)
Hi arsenm:

Thanks for reviewing ! I think you're right. Fixing this in the main framework of CallLowering benefits to all of the big endian user (if any).

I already had some ideas when I hacked on this. I'll put it into practice asap :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116849/new/

https://reviews.llvm.org/D116849