[PATCH] D116849: [M68k][GlobalISel] Fix a big-endian-related bug in CallLowering

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 18:05:47 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/M68k/GISel/M68kCallLowering.cpp:94-96
+    for (auto It = M68kLocs.rbegin(); It != M68kLocs.rend(); ++It) {
+      State.addLoc(*It);
+    }
----------------
I think it would be more appropriate to reverse the order where the parts were split in the first place (i.e. make splitToValueTypes endian aware)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116849/new/

https://reviews.llvm.org/D116849



More information about the llvm-commits mailing list