[PATCH] D115133: [RISCV] Support immediate vtype of VSETVLI/VSETIVLI in asm parser

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 15:52:03 PST 2022


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:25
   let ParserMethod = "parseVTypeI";
   let DiagnosticType = "InvalidVTypeI";
 }
----------------
craig.topper wrote:
> I think you can add
> 
> ```
> let RenderMethod = "addVTypeIOperands";
> ```
> 
> And avoid needing `addVTypeI10Operands` and `addVTypeI11Operands` in the assembler
Thanks for your review, I will commit this patch for her. And will correct this when when doing `git commit` and `git push`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115133/new/

https://reviews.llvm.org/D115133



More information about the llvm-commits mailing list