[PATCH] D115133: [RISCV] Support immediate vtype of VSETVLI/VSETIVLI in asm parser

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 09:06:18 PST 2022


craig.topper added a comment.

LGTM other than trying to use RenderMethod.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:25
   let ParserMethod = "parseVTypeI";
   let DiagnosticType = "InvalidVTypeI";
 }
----------------
I think you can add

```
let RenderMethod = "addVTypeIOperands";
```

And avoid needing `addVTypeI10Operands` and `addVTypeI11Operands` in the assembler


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115133/new/

https://reviews.llvm.org/D115133



More information about the llvm-commits mailing list