[PATCH] D116674: [Docs] Fix IR and TableGen grammar inconsistencies

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

LangRef changes look fine with some nits. Can't comment on the rest.



================
Comment at: llvm/docs/LangRef.rst:742
                          [, section "name"] [, comdat [($name)]]
-                         [, align <Alignment>] (, !name !N)*
+                         [, align <Alignment>] [, partition "name"]
+                         (, !name !N)*
----------------
I'd move partition next to section here.


================
Comment at: llvm/docs/LangRef.rst:840
            [(unnamed_addr|local_unnamed_addr)] [AddrSpace] [fn Attrs]
-           [section "name"] [comdat [($name)]] [align N] [gc] [prefix Constant]
-           [prologue Constant] [personality Constant] (!name !N)* { ... }
+           [section "name"] [section "name"] [comdat [($name)]] [align N]
+           [gc] [prefix Constant] [prologue Constant] [personality Constant]
----------------
Duplicate section, supposed to be partition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116674/new/

https://reviews.llvm.org/D116674