[PATCH] D116674: [Docs] Fix IR and TableGen grammar inconsistencies

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 09:54:44 PST 2022


sebastian-ne created this revision.
sebastian-ne added reviewers: nikic, lebedev.ri.
Herald added subscribers: jdoerfert, pengfei, hiraditya.
sebastian-ne requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

IR:

- globals (and functions, ifuncs, aliases) can have a partition
- catchret has a `to` before the label
- the sint/int types do not exist
- signext comes after the type
- a variable was missing its type

TableGen:

- The second value after a `#` concatenation is optional See e.g. llvm/lib/Target/X86/X86InstrAVX512.td:L3351
- IncludeDirective and PreprocessorDirective were never referenced in the grammar
- Add some missing ;
- Parent classes of multiclasses can have generic arguments. Reuse the `ParentClassList` that is already used in other places.

MIR:

- liveins only allows physical registers, which start with a $


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116674

Files:
  llvm/docs/LangRef.rst
  llvm/docs/TableGen/ProgRef.rst
  llvm/lib/CodeGen/MIRParser/MIParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116674.397624.patch
Type: text/x-patch
Size: 5680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220105/fee3d4c9/attachment.bin>


More information about the llvm-commits mailing list