[PATCH] D116609: [EarlyCSE] Allow elimination of redundant writeonly calls

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 08:31:12 PST 2022


reames added a comment.

A couple notes:

1. writeonly calls can write to their arguments, we should have some test coverage for that case

2. writeonly calls can still throw and infinite-loop.  Since you're removing a following call with the same arguments, we can infer this won't happen, but test coverage and comments needed.

Once tests are added, we can take a closer look at the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116609/new/

https://reviews.llvm.org/D116609



More information about the llvm-commits mailing list