[PATCH] D115615: [MemCpyOpt] Make capture check during call slot optimization more precise

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:961
+    // captured, then the call might be comparing the argument against the
+    // captured dest pointer.
+    Value *DestObj = getUnderlyingObject(cpyDest);
----------------
Oh, please add a comment about how this depends on source not being captured *before* the call as well.  Captured during the call is fine, but we depend on their not being a capture before for the same reason as dest.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115615/new/

https://reviews.llvm.org/D115615