[PATCH] D115615: [MemCpyOpt] Make capture check during call slot optimization more precise

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 4 08:33:34 PST 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:975
+      if (auto *II = dyn_cast<IntrinsicInst>(&I)) {
+        if (II->getIntrinsicID() == Intrinsic::lifetime_end &&
+            II->getArgOperand(1)->stripPointerCasts() == srcAlloca &&
----------------
Aside: We have this slightly error prone pattern repeated in a few places, maybe it's time to add a matcher?  Or helper routine?

(Entirely optional follow up.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115615/new/

https://reviews.llvm.org/D115615



More information about the llvm-commits mailing list