[PATCH] D115594: [AVR] Optimize int16 shift operation for shift amount greater than 8

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 3 19:41:35 PST 2022


aykevl accepted this revision.
aykevl added a comment.
This revision is now accepted and ready to land.

Ok, I think I see why you did it the way you did. Which makes sense given the current architecture.

I suspect shift lowering might be simpler when it is all done in the "expand pseudo instructions" pass instead of splitting it early in ISelLowering. But most of the logic is already in ISelLowering so it makes sense to keep it there, at least for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115594/new/

https://reviews.llvm.org/D115594



More information about the llvm-commits mailing list