[PATCH] D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11455
+  let DecoderMethod = "DecodeCPYMemOpInstruction";
+  let hasNoSchedulingInfo = 1;
+}
----------------
Should this be hasNoSchedulingInfo? Can we remove this or include something very basic?

Should something here be marking them MayLoad and MayStore? They may already be hasSideEffects, as nothing marks them otherwise and they do not have codegen patterns, which is more strict. But it's probably good to be explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116157/new/

https://reviews.llvm.org/D116157