[PATCH] D115786: [SPIR-V 2/n] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 1 13:08:00 PST 2022


rengolin added a comment.

Can't see anything wrong with it but I don't know the SPIRV ISA, so...



================
Comment at: llvm/lib/Target/SPIRV/SPIRVInstrInfo.td:67
+  }
+  if genV then {
+    if genF then {
----------------
I'm guessing `genV` also defines `SF?Cond` and `SI?Cond`? Ie. the `VS` and `VI` are in addition to those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115786/new/

https://reviews.llvm.org/D115786



More information about the llvm-commits mailing list