[PATCH] D116421: [RISCV][LegalizeIntegerTypes] Teach PromoteSetCCOperands not to sext i32 comparisons for RV64 if the promoted values are already zero extended.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 31 04:48:06 PST 2021


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1712
   // zero or sign extension would be valid, use SExtOrZExtPromotedInteger
   // which will choose the cheapest for the target.
+
----------------
Drop the sentence about SExtOrZExtPromotedInteger as we don't appear to use it in here any longer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116421/new/

https://reviews.llvm.org/D116421



More information about the llvm-commits mailing list