[PATCH] D116427: FindTerminfo.cmake: Don't require that C language support be enabled for CMake project.

Jack Andersen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 30 16:53:21 PST 2021


jackoalan requested changes to this revision.
jackoalan added a comment.
This revision now requires changes to proceed.

Thank you for the patch! It makes sense that the check functions depend on the corresponding language to be enabled.

The only issue I see is the converse is also potentially true (where the importer only has C enabled to link with the C API).

It should be written to check C if it is in the `ENABLED_LANGUAGES` global property, and fall back to C++ otherwise.

If you could also make the same modification to `FindFFI.cmake`, this will be a very useful change for importers with C++-only projects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116427/new/

https://reviews.llvm.org/D116427



More information about the llvm-commits mailing list