[PATCH] D116428: Initialize SaveInfo in methods Output::preflightKey and Output::preflightElement.

[Kevin Athey via Phabricator via llvm-commits]

kda created this revision.
kda added a reviewer: vitalybuka.
Herald added subscribers: dexonsmith, hiraditya.
kda requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When enabling MSAN eager mode with noundef analysis these variables were found to not be initialized in unit tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116428

Files:
  llvm/lib/Support/YAMLTraits.cpp


Index: llvm/lib/Support/YAMLTraits.cpp
===================================================================
--- llvm/lib/Support/YAMLTraits.cpp
+++ llvm/lib/Support/YAMLTraits.cpp
@@ -527,8 +527,9 @@
 }
 
 bool Output::preflightKey(const char *Key, bool Required, bool SameAsDefault,
-                          bool &UseDefault, void *&) {
+                          bool &UseDefault, void *&SaveInfo) {
   UseDefault = false;
+  SaveInfo = nullptr;
   if (Required || !SameAsDefault || WriteDefaultValues) {
     auto State = StateStack.back();
     if (State == inFlowMapFirstKey || State == inFlowMapOtherKey) {
@@ -599,7 +600,8 @@
   StateStack.pop_back();
 }
 
-bool Output::preflightElement(unsigned, void *&) {
+bool Output::preflightElement(unsigned, void *&SaveInfo) {
+  SaveInfo = nullptr;
   return true;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116428.396733.patch
Type: text/x-patch
Size: 821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211231/ce6e5a1f/attachment.bin>