[PATCH] D116341: [Opaqueptrs][IR Serialization] Improve inlineasm [de]serialization

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 29 10:01:26 PST 2021


nikic added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:2898
+      unsigned OpNum = 0;
+      auto *FnTy = cast_or_null<FunctionType>(getTypeByID(Record[OpNum]));
+      ++OpNum;
----------------
Shouldn't this be a `dyn_cast<FunctionType>`? We don't want to crash on invalid type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116341/new/

https://reviews.llvm.org/D116341



More information about the llvm-commits mailing list