[PATCH] D116341: [Opaqueptrs][IR Serialization] Improve inlineasm [de]serialization

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 28 12:53:50 PST 2021


lebedev.ri created this revision.
lebedev.ri added reviewers: opaque-pointers, nickdesaulniers, nikic.
lebedev.ri added a project: LLVM.
Herald added a subscriber: hiraditya.
lebedev.ri requested review of this revision.

The bitcode reader expected that the pointers are typed,
so that it can extract the function type for the assembly
so `bitc::CST_CODE_INLINEASM` did not explicitly store said function type.

I'm not really sure how the upgrade path will look for existing bitcode,
but i think we can easily support opaque pointers going forward,
by simply storing the function type.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116341

Files:
  llvm/include/llvm/Bitcode/LLVMBitCodes.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/test/Bitcode/callbr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116341.396423.patch
Type: text/x-patch
Size: 7561 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211228/6d3d0f5f/attachment.bin>


More information about the llvm-commits mailing list