[PATCH] D116021: [AArch64] Add a tablegen pattern for UZP2.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/uzp2.ll:5
+; Test the (concat_vectors (trunc (lshr)), (trunc (lshr))) pattern.
+
+define <16 x i8> @test_combine_v8i16_to_v16i8(<8 x i16> %x, <8 x i16> %y) {
----------------
labrinea wrote:
> SjoerdMeijer wrote:
> > Just a nit about the tests: rather than adding a new file, would it make sense to keep all uzp2 tests together in existing file `arm64-uzp.ll`?
> Can do, but that file doesn't seem to test combination patterns. Maybe I could rename this file into something that indicates combine?
Yeah, that would also work, e.g. `arm64-uzp-combine.ll` or something along those lines would group this together.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116021/new/

https://reviews.llvm.org/D116021