[PATCH] D116021: [AArch64] Add a tablegen pattern for UZP2.

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 21 06:41:03 PST 2021


labrinea added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/uzp2.ll:5
+; Test the (concat_vectors (trunc (lshr)), (trunc (lshr))) pattern.
+
+define <16 x i8> @test_combine_v8i16_to_v16i8(<8 x i16> %x, <8 x i16> %y) {
----------------
SjoerdMeijer wrote:
> Just a nit about the tests: rather than adding a new file, would it make sense to keep all uzp2 tests together in existing file `arm64-uzp.ll`?
Can do, but that file doesn't seem to test combination patterns. Maybe I could rename this file into something that indicates combine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116021/new/

https://reviews.llvm.org/D116021



More information about the llvm-commits mailing list