[PATCH] D116042: [AMDGPU][InstCombine] Remove zero LOD bias

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

I like it.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp:103
+/// SmallVectorImpl<Type *> ArgTys)
+template <typename FuncT>
+static Optional<Instruction *>
----------------
I don't understand why this needs to be a template, if FuncT is always the same as you have documented.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp:143
+                                                     ImageDimIntr->Dim);
+        return modifyIntrinsicCall(
+            II, NewImageDimIntr->Intr, IC, [&](auto &Args, auto &ArgTys) {
----------------
Is it possible that more than one of these optimizations applies to a single intrinsic call, and if so do you handle that case correctly? (E.g. when you apply one optimization, does simplifyAMDGCNImageIntrinsic get called again to apply other optimizations to the new intrinsic?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116042/new/

https://reviews.llvm.org/D116042