[PATCH] D116055: [mlir] Canonicalizer constructor should accept disabled/enabled patterns

[Jeff Niu via Phabricator via llvm-commits]

Mogball added a comment.

In D116055#3203546 <https://reviews.llvm.org/D116055#3203546>, @mehdi_amini wrote:

> In D116055#3203502 <https://reviews.llvm.org/D116055#3203502>, @Mogball wrote:
>
>> Update description of API to match that of FrozenRewritePatternSet.
>>
>> @mehdi_amini I copied the description over from FrozenRewritePatternSet,
>> which is actually where the capability comes from. Based on how this was
>> set up in https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Rewrite/PassUtil.td,
>> I think this is intended to be a somewhat commonly-used API.
>
> Well the issue may be instead into how it is presented in FrozenRewritePatternSet: this does not match the fact that patterns can have naming collision or no name at all (as Ivan indicated).

That's true. I can update the comment over there too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116055/new/

https://reviews.llvm.org/D116055