[PATCH] D116055: [mlir] Canonicalizer constructor should accept disabled/enabled patterns

Mon Dec 20 14:05:13 PST 2021

mehdi_amini added a comment.

In D116055#3203502 <https://reviews.llvm.org/D116055#3203502>, @Mogball wrote:

> Update description of API to match that of FrozenRewritePatternSet.
>
> @mehdi_amini I copied the description over from FrozenRewritePatternSet,
> which is actually where the capability comes from. Based on how this was
> set up in https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Rewrite/PassUtil.td,
> I think this is intended to be a somewhat commonly-used API.

Well the issue may be instead into how it is presented in FrozenRewritePatternSet: this does not match the fact that patterns can have naming collision or no name at all (as Ivan indicated).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116055/new/

https://reviews.llvm.org/D116055