[PATCH] D116042: [AMDGPU][InstCombine] Remove zero LOD bias
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 20 08:44:39 PST 2021
foad added a comment.
In D116042#3203013 <https://reviews.llvm.org/D116042#3203013>, @sebastian-ne wrote:
> In D116042#3202985 <https://reviews.llvm.org/D116042#3202985>, @foad wrote:
>
>> If we do it at the IR level, why do we need this patch?
>
> Oh, my question was meant to ask if I should do 1. push this patch, 2. move all combines to IR combines, or if it should be 1. move the existing optimizations to IR combines, 2. implement the zero bias optimization as IR combine.
It seems a bit silly to review and push this code if you are planning to remove it again. But I don't really mind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116042/new/
https://reviews.llvm.org/D116042
More information about the llvm-commits
mailing list