[PATCH] D116034: Prevent copy of AttrBuilder
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 20 07:33:50 PST 2021
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9cd55c7c3463: Prevent copy of AttrBuilder (authored by serge-sans-paille).
Changed prior to commit:
https://reviews.llvm.org/D116034?vs=395420&id=395446#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116034/new/
https://reviews.llvm.org/D116034
Files:
llvm/include/llvm/IR/Attributes.h
llvm/lib/IR/Verifier.cpp
Index: llvm/lib/IR/Verifier.cpp
===================================================================
--- llvm/lib/IR/Verifier.cpp
+++ llvm/lib/IR/Verifier.cpp
@@ -543,7 +543,7 @@
void verifySwiftErrorCall(CallBase &Call, const Value *SwiftErrorVal);
void verifySwiftErrorValue(const Value *SwiftErrorVal);
- void verifyTailCCMustTailAttrs(AttrBuilder Attrs, StringRef Context);
+ void verifyTailCCMustTailAttrs(const AttrBuilder &Attrs, StringRef Context);
void verifyMustTailCall(CallInst &CI);
bool verifyAttributeCount(AttributeList Attrs, unsigned Params);
void verifyAttributeTypes(AttributeSet Attrs, const Value *V);
@@ -3314,7 +3314,7 @@
visitInstruction(Call);
}
-void Verifier::verifyTailCCMustTailAttrs(AttrBuilder Attrs,
+void Verifier::verifyTailCCMustTailAttrs(const AttrBuilder &Attrs,
StringRef Context) {
Assert(!Attrs.contains(Attribute::InAlloca),
Twine("inalloca attribute not allowed in ") + Context);
Index: llvm/include/llvm/IR/Attributes.h
===================================================================
--- llvm/include/llvm/IR/Attributes.h
+++ llvm/include/llvm/IR/Attributes.h
@@ -944,6 +944,8 @@
public:
AttrBuilder() = default;
+ AttrBuilder(const AttrBuilder &) = delete;
+ AttrBuilder(AttrBuilder &&) = default;
AttrBuilder(const Attribute &A) {
addAttribute(A);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116034.395446.patch
Type: text/x-patch
Size: 1395 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211220/f036c581/attachment.bin>
More information about the llvm-commits
mailing list