[PATCH] D116034: Prevent copy of AttrBuilder

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/include/llvm/IR/Attributes.h:966
   AttrBuilder() = default;
+  AttrBuilder(AttrBuilder const&) = delete;
+  AttrBuilder(AttrBuilder &&) = default;
----------------
nit: `const AttrBuilder &` would be more typical.


================
Comment at: llvm/lib/IR/Verifier.cpp:3317
 
-void Verifier::verifyTailCCMustTailAttrs(AttrBuilder Attrs,
+void Verifier::verifyTailCCMustTailAttrs(const AttrBuilder & Attrs,
                                          StringRef Context) {
----------------
nit: Extra space after `&`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116034/new/

https://reviews.llvm.org/D116034