[PATCH] D115874: [M68k][GlobalISel] Add basic function call and instruction selection support

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 19 21:29:57 PST 2021


0x59616e added a comment.

In D115874#3202014 <https://reviews.llvm.org/D115874#3202014>, @myhsu wrote:

>> Also there is a little problem: GlobalISel reject to combine G_LOAD followed by G_STORE into a move <ea>, <ea> unless there're consecutive in order. That is to say, if there is any instruction between them, GlobalISel will generate weird code like this:
>
> Some of the `move <ea>, <ea>` definitions are actually missing IIRC. I'm tidying up all the MOVE instructions (to add those missing definitions, for instance) as part of the D115128 <https://reviews.llvm.org/D115128> series and I think that will solve this problem.

I got it. Thanks for your hard work! I won't touch that part until you've done :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115874/new/

https://reviews.llvm.org/D115874



More information about the llvm-commits mailing list