[PATCH] D115874: [M68k][GlobalISel] Add basic function call and instruction selection support

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 19 21:28:13 PST 2021


0x59616e added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrData.td:71
     : MxMove<REG.Prefix, (outs), (ins MEMOpd:$dst, REG.ROp:$src),
-             [(store REG.VT:$src, MEMPat:$dst)], ENC>;
+             [(store REG.VT:$src, (MEMPat MEMOpd:$dst))], ENC>;
 
----------------
myhsu wrote:
> is there any particular reason you made this change? Like, some restrictions imposed by GISel?
Yes, GISel rejects the original pattern. It says "Dst operand has an unsupported type"

The SelectionDAG isn't affected. The MatcherTable is still the same after this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115874/new/

https://reviews.llvm.org/D115874



More information about the llvm-commits mailing list