[PATCH] D114419: [XCOFF] change default program code csect alignment to 32

Sat Dec 18 05:03:02 PST 2021

shchenz added inline comments.

================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:1050
+  // as the default alignment, while DWARF sections have their own alignments,
+  // if these two alignments are not the same, we need some paddings here.
+  if (!DwarfSections.empty())
----------------
jsji wrote:
> these are unrelated to the default alignment change? If we change the text alignment with `-align-all-functions` , we also need to deal with these? If so, please split these changes into another patch.
Right, if the DWARF csect alignment is the same as the section alignment defined in this file(`DefaultSectionAlign=4`), we are ok. But if they are not the same, we will have some issue. This is to fix this issue. I will split them into another patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114419/new/

https://reviews.llvm.org/D114419