[PATCH] D114419: [XCOFF] change default program code csect alignment to 32

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 07:43:41 PST 2021


jsji added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:1050
+  // as the default alignment, while DWARF sections have their own alignments,
+  // if these two alignments are not the same, we need some paddings here.
+  if (!DwarfSections.empty())
----------------
these are unrelated to the default alignment change? If we change the text alignment with `-align-all-functions` , we also need to deal with these? If so, please split these changes into another patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114419/new/

https://reviews.llvm.org/D114419



More information about the llvm-commits mailing list