[PATCH] D115957: [Support] Revert posix_fallocate in resize_file

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D115957#3200631 <https://reviews.llvm.org/D115957#3200631>, @emaste wrote:

>> it is likely Linux specific
>
> Using it to prevent disk-full would equally apply to FreeBSD and other operating systems as Linux, on non-CoW filesystems.
>
> Anyhow, the original motivation was early detection of disk-full not performance. I wouldn't really expect a performance benefit. I don't object to removing use of `posix_fallocate()` but as it wasn't intended as a performance improvement IMO removing it is not justified by lack of performance benefit.

It greatly harms performance on Linux tmpfs, 0.3s in my 5.2s link.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115957/new/

https://reviews.llvm.org/D115957