[PATCH] D115957: [Support] Revert posix_fallocate in resize_file

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 12:24:44 PST 2021


emaste added a comment.

> it is likely Linux specific

Using it to prevent disk-full would equally apply to FreeBSD and other operating systems as Linux, on non-CoW filesystems.

Anyhow, the original motivation was early detection of disk-full not performance. I wouldn't really expect a performance benefit. I don't object to removing use of `posix_fallocate()` but as it wasn't intended as a performance improvement IMO removing it is not justified by lack of performance benefit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115957/new/

https://reviews.llvm.org/D115957



More information about the llvm-commits mailing list