[PATCH] D115961: [funcattrs] Fix incorrect readnone/readonly inference on captured arguments

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 12:48:52 PST 2021


reames added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:702
+          // if a reloaded copy is written to, thus we must give up.
+          return Attribute::None;
+        // Push users for processing once we finish this one
----------------
jdoerfert wrote:
> I don't know if it is checked but unwinding is the same issue as writes. The Attributor code might have even more corner cases covered.
I don't believe we can have a well defined readonly throwing function.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115961/new/

https://reviews.llvm.org/D115961



More information about the llvm-commits mailing list