[PATCH] D115961: [funcattrs] Fix incorrect readnone/readonly inference on captured arguments

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Drive-by, I'm on vacation.

Glad someone fixes this, even if I was hoping we replace all this by invoking the Attributor only for the IR attributes we are looking for here.



================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:702
+          // if a reloaded copy is written to, thus we must give up.
+          return Attribute::None;
+        // Push users for processing once we finish this one
----------------
I don't know if it is checked but unwinding is the same issue as writes. The Attributor code might have even more corner cases covered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115961/new/

https://reviews.llvm.org/D115961