[PATCH] D115880: [AMDGPU] Generate assertions for lds-atomic-fadd.ll and local-atomics-fp.ll.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 10:58:34 PST 2021


rampitec added a comment.

In D115880#3199545 <https://reviews.llvm.org/D115880#3199545>, @abinavpp wrote:

> In D115880#3198240 <https://reviews.llvm.org/D115880#3198240>, @rampitec wrote:
>
>> I do not believe really needed for D115881 <https://reviews.llvm.org/D115881>.
>
> This is to show the change in SIInsertWaitcnts for local-atomics-fp.ll in D115881 <https://reviews.llvm.org/D115881> at the moment. If we fix the problems in D115881 <https://reviews.llvm.org/D115881>, hopefully the regression should go away. In that case, this change is a mere test generation.

I think D115881 <https://reviews.llvm.org/D115881> shall be fixed not to have that regression. Then this change is not needed too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115880/new/

https://reviews.llvm.org/D115880



More information about the llvm-commits mailing list