[PATCH] D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF.
ChenZheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 17 00:43:41 PST 2021
shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for adding this support.
One minor comment: need to update the doc for PowerPC for `--symbolize-operands` option in `llvm-objdump.rst`.
Better to wait for some days before committing.
================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-symbolize-operands.ll:6
+;; Expect to find the branch labels.
+; CHECK-LABEL: <.text>:
+; CHECK-NEXT: 0: mr 4, 3
----------------
This seems not right, expect `.internal` here. I guess it should be a legacy issue. Should be ok to do this in another patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114492/new/
https://reviews.llvm.org/D114492
More information about the llvm-commits
mailing list