[PATCH] D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF.

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 00:07:59 PST 2021


Esme added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1006
+          !Labels.count(Target) &&
+          !(STI->getTargetTriple().isPPC() && Target == Index))
         Labels[Target] = ("L" + Twine(LabelCount++)).str();
----------------
shchenz wrote:
> Can this logic be added in `PPCMCInstrAnalysis`? So we don't need the target check here.
I think we should return true for such cases in evaluateBranch(), because they are indeed branch operands, and their targets should be printed just like the behavior of system objdump when no `--symbolize-operands` is requires.
```
      88:      	bl 0x88 <foo+0x48>
      8c:      	nop
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114492/new/

https://reviews.llvm.org/D114492



More information about the llvm-commits mailing list