[PATCH] D115775: [lld-macho] Handle $ld$hide[$os] symbols.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added a comment.

Interestingly, the two-pass approach seemed faster 🤔 .
In any case, I guess we're good. :)

  SYSTEM CPU time: 
  x one_pass.txt
  + two_passes.txt
      N           Min           Max        Median           Avg        Stddev
  x   5          1.08          1.19           1.1         1.116   0.046151923
  +   5          0.91          1.04          0.93          0.95   0.054313902
  Difference at 95.0% confidence
  	-0.166 +/- 0.0735032
  	-14.8746% +/- 6.58631%
  	(Student's t, pooled s = 0.0503984)
  
  USER CPU time: 
  x one_pass.txt
  + two_passes.txt
      N           Min           Max        Median           Avg        Stddev
  x   5          3.28           3.4          3.36          3.35    0.04472136
  +   5          3.13           3.3          3.18         3.192   0.068337398
  Difference at 95.0% confidence
  	-0.158 +/- 0.0842243
  	-4.71642% +/- 2.51416%
  	(Student's t, pooled s = 0.0577495)
  
  WALL time: 
  x one_pass.txt
  + two_passes.txt
      N           Min           Max        Median           Avg        Stddev
  x   5          5.54          5.65          5.62         5.608   0.042071368
  +   5          4.79          5.31          4.93         4.966    0.21173096
  Difference at 95.0% confidence
  	-0.642 +/- 0.222622
  	-11.4479% +/- 3.96971%
  	(Student's t, pooled s = 0.152643)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115775/new/

https://reviews.llvm.org/D115775