[PATCH] D115775: [lld-macho] Handle $ld$hide[$os] symbols.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo updated this revision to Diff 394968.
oontvoo added a comment.
Herald added a subscriber: cishida.

Updated diff: process all the $ld symbols. First.

Benchmarking this on chromium vs the previous diff showed little difference

  SYSTEM CPU time: 
  x one_pass.txt
  + two_passes.txt
      N           Min           Max        Median           Avg        Stddev
  x   5          1.05          1.08          1.05         1.058   0.013038405
  +   5          1.06          1.09          1.08         1.074   0.013416408
  No difference proven at 95.0% confidence
  
  USER CPU time: 
  x one_pass.txt
  + two_passes.txt
      N           Min           Max        Median           Avg        Stddev
  x   5          3.57          3.65          3.58         3.596   0.032093613
  +   5           3.6           3.7          3.61         3.634   0.044497191
  No difference proven at 95.0% confidence
  
  WALL time: 
  x one_pass.txt
  + two_passes.txt
      N           Min           Max        Median           Avg        Stddev
  x   5          4.14          4.26          4.15         4.176    0.04929503
  +   5          4.17          4.31           4.2         4.226   0.061073726
  No difference proven at 95.0% confidence

(though I suspect it *might* make a difference with a larger app like Youtube ... will try benchmarking it later today)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115775/new/

https://reviews.llvm.org/D115775

Files:
  lld/MachO/InputFiles.cpp
  lld/MachO/InputFiles.h
  lld/test/MachO/special-symbol-ld-hidden.s
  llvm/include/llvm/TextAPI/InterfaceFile.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115775.394968.patch
Type: text/x-patch
Size: 8548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211216/36ebbfdc/attachment.bin>