[PATCH] D115853: [RISCV][ABI] Have ABI checks for ilp32e under AsmParser and TargetLowering

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

In D115853#3197551 <https://reviews.llvm.org/D115853#3197551>, @luismarques wrote:

> The new error message in RISCVISelLowering.cpp isn't yet covered by tests but that line currently isn't reachable due to the `report_fatal_error` in line 52. It's not ideal that this can't have test coverage. @asb thoughts?

I was assuming that it would be a bad idea to remove the `report_fatal_error` because code generation would still occur (despite the error message) and possibly crash in unpleasant ways but maybe that's not significantly different from the other error conditions above where that also happens.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115853/new/

https://reviews.llvm.org/D115853