[PATCH] D115853: [RISCV][ABI] Have ABI checks for ilp32e under AsmParser and TargetLowering

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

In D115853#3197131 <https://reviews.llvm.org/D115853#3197131>, @eopXD wrote:

> I think this patch only addresses the TODO and has no behavioral change.

I suggest renaming the title to "[RISCV][NFC] Move ilp32e/rv32e checks to AsmParser and TargetLowering", to make it clearer that this is just a refactoring.

> Test case is already covered under `llvm/test/MC/RISCV/target-abi-invalid.s`.

The new error message in RISCVISelLowering.cpp isn't yet covered by tests but that line currently isn't reachable due to the `report_fatal_error` in line 52. It's not ideal that this can't have test coverage. @asb thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115853/new/

https://reviews.llvm.org/D115853