[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

[Patryk Wychowaniec via Phabricator via llvm-commits]

Patryk27 added inline comments.


================
Comment at: llvm/test/CodeGen/AVR/regression/D114611.ll:1
+; RUN: llc < %s -march=avr | FileCheck %s
+
----------------
arsenm wrote:
> Patryk27 wrote:
> > dylanmckay wrote:
> > > I like the idea of moving the "bug coverage" tests to a subdir.
> > > 
> > > What do you reckon about renaming the directory `past-bugs` or something else rather than `regression`. The latter feels to generic - all of the tests, even outside the AVR directory, are there for regression so the name feels a bit meaningless. 
> > I've named it `regression` after `AMDGPU`'s one, but sure - `past-bugs` sounds fine, too :-)
> AMDGPU does not have regression subdirectory. Also I don't see any clear distinction between a regression test and any other
There's https://github.com/llvm/llvm-project/tree/60f5614931b43871791393df74689d3b2b05c329/llvm/test/MC/AMDGPU/regression.

I was under the impression that a "regression test" meant a "test for a past bug" (under which condition e.g. our `or.ll` wouldn't be technically a regression test, but a typical unit / integration one). But yeah, seems like this phrase has a more general meaning that I thought.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114611/new/

https://reviews.llvm.org/D114611