[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 15 16:12:06 PST 2021


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AVR/regression/D114611.ll:1
+; RUN: llc < %s -march=avr | FileCheck %s
+
----------------
Patryk27 wrote:
> dylanmckay wrote:
> > I like the idea of moving the "bug coverage" tests to a subdir.
> > 
> > What do you reckon about renaming the directory `past-bugs` or something else rather than `regression`. The latter feels to generic - all of the tests, even outside the AVR directory, are there for regression so the name feels a bit meaningless. 
> I've named it `regression` after `AMDGPU`'s one, but sure - `past-bugs` sounds fine, too :-)
AMDGPU does not have regression subdirectory. Also I don't see any clear distinction between a regression test and any other


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114611/new/

https://reviews.llvm.org/D114611



More information about the llvm-commits mailing list