[PATCH] D115841: [llvm-profgen] Warn for empty LBR of hybrid sample instead of error

Wed Dec 15 21:25:09 PST 2021

wlei abandoned this revision.
wlei added a comment.

In D115841#3196542 <https://reviews.llvm.org/D115841#3196542>, @wenlei wrote:

> In D115841#3196500 <https://reviews.llvm.org/D115841#3196500>, @wlei wrote:
>
>> In D115841#3196483 <https://reviews.llvm.org/D115841#3196483>, @wenlei wrote:
>>
>>> Wondering why we would have such cases?
>>
>> ok..It turned out I used the incomplete input, the last sample is truncated like:
>>
>>   106db8f0
>>   cf481a1
>>   cf47ec7
>>   106c0fc7
>>   106c0cbb
>>   106c0c3c
>>   cf444df
>>   cf458e9
>>   ceef560
>>   ceecfb8
>>   ceea6ae
>>   cee7ced
>>   cef70ad
>>   cf2b
>>
>> The complete sample in the service won't have the case. so seems we don't need this.
>
> Ok, then it probably makes more sense to treat it as error still.

Sounds good, abandoning it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115841/new/

https://reviews.llvm.org/D115841