[PATCH] D115841: [llvm-profgen] Warn for empty LBR of hybrid sample instead of error
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 15 21:04:43 PST 2021
wenlei added a comment.
In D115841#3196500 <https://reviews.llvm.org/D115841#3196500>, @wlei wrote:
> In D115841#3196483 <https://reviews.llvm.org/D115841#3196483>, @wenlei wrote:
>
>> Wondering why we would have such cases?
>
> ok..It turned out I used the incomplete input, the last sample is truncated like:
>
> 106db8f0
> cf481a1
> cf47ec7
> 106c0fc7
> 106c0cbb
> 106c0c3c
> cf444df
> cf458e9
> ceef560
> ceecfb8
> ceea6ae
> cee7ced
> cef70ad
> cf2b
>
> The complete sample in the service won't have the case. so seems we don't need this.
Ok, then it probably makes more sense to treat it as error still.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115841/new/
https://reviews.llvm.org/D115841
More information about the llvm-commits
mailing list