[PATCH] D115775: [lld-macho] Handle $ld$hide[$os] symbols.

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:1388
+    }
+    shouldHide = versionTup == config->platformInfo.minimum;
+  } else
----------------
oontvoo wrote:
> keith wrote:
> > int3 wrote:
> > > is this really `==` and not `<=`?
> > is == there right comparison here? not entirely sure of the use cases but should a .1 difference still have this logic apply?
> Yes,  `==` is by design. We want exact version match.
> 
> Apparently, apple would list literally all the versions it wants to hide in the tbd (rather than using a min version).
> Eg., if you want to hide `foo` for 10, 11, and 12, then you would need `$ld$hide$os10.0$foo`, `$ld$hide$os11.0$foo`, `$ld$hide$os12.0$foo`
> 
oops, ignore this comment, forgot to delete it after I saw your reply to keith


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115775/new/

https://reviews.llvm.org/D115775