[PATCH] D115775: [lld-macho] Handle $ld$hide[$os] symbols.

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:1251-1253
+    // FIXME: We could process all the $ld$hide symbols first
+    // then the "normal" symbols to avoid inserting then deleting from
+    // symtab.
----------------
this would be a much cleaner implementation IMO. could we do a few quick benchmarks to see if it actually makes a perf difference? if not, simpler is better :)


================
Comment at: lld/MachO/InputFiles.cpp:1388
+    }
+    shouldHide = versionTup == config->platformInfo.minimum;
+  } else
----------------
is this really `==` and not `<=`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115775/new/

https://reviews.llvm.org/D115775